Merged a lot of PRs

[bhaskarvk]

I've merged PRs
#46
#48
#50
#51
#60
#75
#76
#77
#78

and also fixed the examples.

[george-silva]

@bhaskarvk can you direct that to the new repo?

[bhaskarvk]

Will do

[bhaskarvk]

Actually I can't, because your repo is not a proper fork of original repo. So GH is not allowing me to create a PR on your repo. Could you make your repo a fork of the original repo, that way I can submit a PR on your repo.

[george-silva]

@bhaskarvk I asked GitHub to detach the fork, because without that, I would not be able to create issues.

If it's not too much work, I can give you permission on the repo, and you can merge (if everything is tested and ok), directly in the repository. That would make you a contributor as well ;)

You basically would just add a new remote and push to it.

[bhaskarvk]

Could I make an alternate suggestion ? Even if your repo is detached from this repo, you can still add this repo as an upstream repo to your local checkout.

git remote add upstream https://github.com/lvoogdt/Leaflet.awesome-markers

Then open .git/config and add
fetch = +refs/pull/*/head:refs/remotes/upstream/pr/* beneath your upstream repo config part.

So it should look something like

[remote "upstream"]
	url = https://github.com/lvoogdt/Leaflet.awesome-markers
	fetch = +refs/heads/*:refs/remotes/upstream/*
	fetch = +refs/pull/*/head:refs/remotes/upstream/pr/*

Then do git fetch origin which should fetch my PR.
Then you can merge it with your local copy and push it to your fork.

[theashyster]

@bhaskarvk @george-silva What is the status on this? Are you going to put these changes in the new repo?

[george-silva]

@theashyster the new repo is already setup with releases to npm and bower. I haven't merged the PR from @bhaskarvk .

@bhaskarvk can you PR to that repo instead?

[theashyster]

@george-silva Maybe you can do the suggestion from this comment? #80 (comment)

[george-silva]

The PR is open at: sigma-geosistemas/Leaflet.awesome-markers#8

Please, help me with testing 😄

Thanks everyone.

[jgravois]

@bhaskarvk just fyi, you can 'turn on' issues in a fork via:

Settings > Features

• Issues

[bhaskarvk]

@jgravois That's for @george-silva to do on his repo. My fork is not the official successor, his is.