Remove default value for shared - Fixes #28

CHANGELOG.md

@@ -1,5 +1,24 @@
 # Changelog
 
+## 2017-11-21 - Bugfix release 2.0.2
+
+Published at [Puppet Forge](https://forge.puppet.com/leoarnold/cups/2.0.2)
+and [GitHub](https://github.com/leoarnold/puppet-cups/releases/tag/2.0.2).
+
+### Summary
+
+This release fixes a conflict when using remotely shared queues.
+
+### Bugfixes
+
+- Removed the default value `shared => false` for type `cups_queue`
+  in order to comply with [CUPS #4766](https://github.com/apple/cups/issues/4766)
+
+## 2017-11-16 - Official Approval by Puppet Inc
+
+We are proud to announce that Puppet Inc [officially approved](https://tickets.puppetlabs.com/browse/MODULES-5903)
+version 2.0.1 of this module.
+
 ## 2017-11-09 - Service release 2.0.1
 
 Published at [Puppet Forge](https://forge.puppet.com/leoarnold/cups/2.0.1)

README.md

@@ -549,7 +549,7 @@ Installs and manages CUPS print queues.
   on the node for a list of all supported options for the given queue, and `lpoptions -p [queue_name] -l`
   to see a list of available values for the most commonly used printer specific options.
 
-* `shared`: Boolean value specifying whether to share this queue on the network. Default is `false`.
+* `shared`: Boolean value specifying whether to share this queue on the network.
 
 ##### Class-only attributes
 

lib/puppet/type/cups_queue.rb

@@ -281,10 +281,9 @@ def should_to_s(newvalue)
   end
 
   newproperty(:shared) do
-    desc 'Boolean value specifying whether to share this queue on the network. Default is `false`.'
+    desc 'Boolean value specifying whether to share this queue on the network.'
 
     newvalues(:true, :false)
-    defaultto(:false)
   end
 
   newproperty(:uri) do

metadata.json

@@ -1,6 +1,6 @@
 {
   "name": "leoarnold-cups",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "author": "Leo Arnold",
   "summary": "Puppet module for the Common Unix Printing System (CUPS)",
   "license": "MIT",

spec/acceptance/puppet/cups_issue_4766_spec.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require 'spec_helper_acceptance'
+
+# See also: https://github.com/leoarnold/puppet-cups/issues/28
+RSpec.describe 'Circumventing CUPS issue #4766' do
+  before(:all) do
+    ensure_cups_is_running
+  end
+
+  context 'ensuring a queue' do
+    context "when is shared via IPP by some remote host and 'shared'" do
+      context 'is not specified' do
+        before(:all) do
+          purge_all_queues
+        end
+
+        manifest = <<-MANIFEST
+          cups_queue { 'Office':
+            ensure  => 'printer',
+            uri     => 'ipp://192.168.10.20/printers/Office',
+          }
+        MANIFEST
+
+        it 'applies changes' do
+          apply_manifest(manifest, expect_changes: true)
+        end
+
+        it 'is idempotent' do
+          apply_manifest(manifest, catch_changes: true)
+        end
+      end
+
+      context '=> true' do
+        before(:all) do
+          purge_all_queues
+        end
+
+        manifest = <<-MANIFEST
+          cups_queue { 'Office':
+            ensure  => 'printer',
+            uri     => 'ipp://192.168.10.20/printers/Office',
+            shared  => true
+          }
+        MANIFEST
+
+        it 'it fails to apply changes' do
+          command = apply_manifest(manifest, expect_failures: true)
+
+          expect(command.stderr).to include('printer-is-shared for remote queues')
+        end
+      end
+
+      context '=> false' do
+        before(:all) do
+          purge_all_queues
+        end
+
+        manifest = <<-MANIFEST
+          cups_queue { 'Office':
+            ensure  => 'printer',
+            uri     => 'ipp://192.168.10.20/printers/Office',
+            shared  => false
+          }
+        MANIFEST
+
+        it 'it fails to apply changes' do
+          command = apply_manifest(manifest, expect_failures: true)
+
+          expect(command.stderr).to include('printer-is-shared for remote queues')
+        end
+      end
+    end
+  end
+end

spec/unit/puppet/provider/cups_queue/cups_spec.rb

@@ -105,7 +105,6 @@
         it 'installs the class with default values' do
           expect(@provider).to receive(:lpadmin).with('-E', '-p', 'Office', '-c', 'GroundFloor')
           expect(@provider).to receive(:lpadmin).with('-E', '-p', 'Warehouse', '-c', 'GroundFloor')
-          expect(@provider).to receive(:lpadmin).with('-E', '-p', 'GroundFloor', '-o', 'printer-is-shared=false')
 
           @provider.create_class
         end
@@ -137,7 +136,6 @@
           allow(@provider).to receive(:lpadmin).with('-E', '-x', 'Office')
           expect(@provider).to receive(:lpadmin).with('-E', '-p', 'Office', '-v', 'file:///dev/null')
           expect(@provider).to receive(:lpadmin).with('-E', '-p', 'Office', switch[method], manifest[method]) if method
-          expect(@provider).to receive(:lpadmin).with('-E', '-p', 'Office', '-o', 'printer-is-shared=false')
           expect(@provider).to receive(:check_make_and_model)
 
           @provider.create_printer

spec/unit/puppet/type/cups_queue_spec.rb

@@ -743,11 +743,6 @@
         expect(type.attrclass(:shared).doc.length).to be > 20
       end
 
-      it "defaults to 'false'" do
-        resource = type.new(name: 'Office')
-        expect(resource[:shared]).to eq(:false)
-      end
-
       it 'accepts boolean values' do
         @resource[:shared] = :true
         expect(@resource[:shared]).to eq(:true)