Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename db tables to have more consistency #434

Merged
merged 9 commits into from
Jul 3, 2024

Conversation

diegoalzate
Copy link
Contributor

@diegoalzate diegoalzate commented Jun 25, 2024

overview

removes prefix for question_options -> options and forum_question -> question

side effect changes:

@diegoalzate diegoalzate added the improvement improving an existing feature label Jun 25, 2024
@diegoalzate diegoalzate self-assigned this Jun 25, 2024
Copy link
Collaborator

@MartinBenediktBusch MartinBenediktBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@diegoalzate diegoalzate changed the base branch from develop to next-v2.6.0 July 2, 2024 11:04
Copy link
Collaborator

@MartinBenediktBusch MartinBenediktBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diegoalzate diegoalzate merged commit 7f9c676 into next-v2.6.0 Jul 3, 2024
3 checks passed
@diegoalzate diegoalzate deleted the diego/rename-db-tables branch July 3, 2024 19:50
diegoalzate added a commit that referenced this pull request Jul 30, 2024
* rename db tables to have more consistency

* fix renaming variables

* fix tests

* update property names

* drop db changes

* create new migration starting from vote model changes

* update github actions pnpm setup to v4 to stop breaking actions issue

* fix tests

---------

Co-authored-by: Martin Benedikt Busch <bene.busch1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants