Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "test" for Debug representation of various C API symbolize types #249

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

danielocfb
Copy link
Collaborator

Code coverage is highlighting a bunch of "red" on the #[derive(Debug)] annotations on the various C API symbolize types. Add tests for them.

Code coverage is highlighting a bunch of "red" on the #[derive(Debug)]
annotations on the various C API symbolize types. Add tests for them.

Signed-off-by: Daniel Müller <deso@posteo.net>
Code coverage is highlighting a bunch of "red" on the #[derive(Debug)]
annotations on the various C API normalize types. Add tests for them.

Signed-off-by: Daniel Müller <deso@posteo.net>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.53 🎉

Comparison is base (5db0737) 80.44% compared to head (51c653e) 85.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   80.44%   85.97%   +5.53%     
==========================================
  Files          28       28              
  Lines        3845     3958     +113     
==========================================
+ Hits         3093     3403     +310     
+ Misses        752      555     -197     
Impacted Files Coverage Δ
src/c_api/inspect.rs 96.50% <100.00%> (+17.10%) ⬆️
src/c_api/normalize.rs 93.31% <100.00%> (+26.21%) ⬆️
src/c_api/symbolize.rs 94.19% <100.00%> (+36.29%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Code coverage is highlighting a bunch of "red" on the #[derive(Debug)]
annotations on the various C API inspect types. Add tests for them.

Signed-off-by: Daniel Müller <deso@posteo.net>
@danielocfb danielocfb force-pushed the topic/debug-repr branch 2 times, most recently from b14a326 to 51c653e Compare July 11, 2023 17:47
@danielocfb
Copy link
Collaborator Author

While the #[derive(Debug)] annotations don't actually show up in the "new coverage" UI, they are actually reported as covered now
screenshot-2023-07-11_11-30-28

So I think this fixes the issue.

@danielocfb danielocfb merged commit b6856fb into libbpf:main Jul 11, 2023
22 checks passed
@danielocfb danielocfb deleted the topic/debug-repr branch July 11, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants