Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-38296 Modified pod template to include pod logs #1653

Merged
merged 3 commits into from
Sep 1, 2024

Conversation

kachaudhary-px
Copy link
Collaborator

@kachaudhary-px kachaudhary-px commented Aug 20, 2024

This PR has changes in the pod template and creates new pod to collect the portworx pod logs.

  • PWX-38296

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.49%. Comparing base (21913bd) to head (5b46967).

Files Patch % Lines
pkg/controller/portworxdiag/portworxdiag.go 9.09% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           hk-feature-clusterDiags    #1653      +/-   ##
===========================================================
+ Coverage                    77.90%   79.49%   +1.58%     
===========================================================
  Files                           63       63              
  Lines                        19072    19084      +12     
===========================================================
+ Hits                         14858    15170     +312     
+ Misses                        3130     2812     -318     
- Partials                      1084     1102      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR is stale because it has been in review for 3 days with no activity.

@kachaudhary-px kachaudhary-px merged commit 6d78d0c into hk-feature-clusterDiags Sep 1, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant