Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable write coalescing #61

Merged
merged 2 commits into from
May 23, 2019
Merged

disable write coalescing #61

merged 2 commits into from
May 23, 2019

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien requested a review from vyzo May 23, 2019 01:00
vyzo
vyzo requested changes May 23, 2019
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we simply set the default coalesce timeout to 0?

@vyzo
Copy link
Contributor

vyzo commented May 23, 2019

to answer my own question: no, it will still coalesce buffered writes.

vyzo
vyzo approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@vyzo vyzo mentioned this pull request May 23, 2019
Closed
@Stebalien Stebalien merged commit fd72cdc into master May 23, 2019
@Stebalien Stebalien deleted the fix/disable-write-coalescing branch May 23, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @vyzo