build: switch from dep to go modules #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we remove the dep section as we no longer use it, and instead use go modues.
In this commit, we remove the travis section as the directive has been removed from the makefile.
with '#' will be ignored, and an empty message aborts the commit.
In this commit, we update the makefile to be aware of go modules. Along the way, we remove all references to dep as we no longer use it within this project. Note that in order to allow usage of go modules within the $GOPATH directory, we set the `GO111MODULE=on` environment variable.
cfromknecht
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we switch from using
depfor our dependency management to using go modules instead. This change is made possible by #1892. As a result of these set of changes,lndno longer needs to live in the$GOPATH! Instead, it can now live anywhere on ones file system. Go modules will automatically be activated if it detects a build happening outside the$GOPATH. In order to activate support within the$GOPATH, the following environment variable needs to be set when building:GO111MODULE=on. Once go 1.12 is released, this will no longer be required however.All relevant documentation has been updated to reflect the new building commands (no more
depis it really). We also update themakefileto use the environment variable as necessary, and read commit hashes fromgo.suminstead ofGopkg.lock. Now that we have build caching, we can also safely cache the directory that Go uses to store the modules information. This should further speed up our builds.