lnwire+peer: fully validate node aliases on the wire, don't d/c due to invalid aliases #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
previously approved these changes
Jan 4, 2019
Roasbeef
force-pushed
the
node-alias-validation
branch
from
a121061
to
7100288
Compare
|
Comment addressed, PTAL @halseth |
halseth
reviewed
Jan 7, 2019
peer.go
Outdated
| // If the NodeAnnouncement has an invalid alias, then | ||
| // we'll log that error above and continue so we can | ||
| // continue to read messges from the peer. | ||
| case lnwire.ErrInvalidNodeAlias: |
There was a problem hiding this comment.
This should have a test if possible. I think maybe this should be a pointer as well?
There was a problem hiding this comment.
There isn't a good way to make an accurate end to end test for this as we don't allow local nodes to set the value, and we don't yet have a p2p testing framework in place. Correct on pointer, just added! We do currently have unit tests that cover validation however.
In this commit, we ensure that when we read node aliases from the wire, we ensure that they're valid. Before this commit, we would read the raw bytes without checking for validity which could result in us writing in invalid node alias to disk. We've fixed this, and also updated the quickcheck tests to generate valid strings.
Roasbeef
force-pushed
the
node-alias-validation
branch
from
7100288
to
a49e39d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.