Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoices: fix SQL invoice query pagination #8854

Merged
merged 3 commits into from
Jul 4, 2024
Merged

invoices: fix SQL invoice query pagination #8854

merged 3 commits into from
Jul 4, 2024

Commits on Jul 4, 2024

  1. invoices: fix and correctly cover paginated queries 

    Previously paginated queries offseted the add_index_get, add_index_let,
settle_index_get and settle_index_let parameters with the paginators
current page offset, however this was incorrect as we can just use
SQL's LIMIT/OFFSET to paginate. This commit fixes this issue and adds an
optional parameter to the constructor of the invoice SQL store to set
page size. This is useful when testing as we can now cover pagination
correctly with our existing unit tests.
    @bhandras
    bhandras committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    e45ed86 View commit details
    Browse the repository at this point in the history

  2. sqldb: bump modernc.org/sqlite to 1.29.10 which fixes init data race 

    Tracking issue: https://gitlab.com/cznic/sqlite/-/issues/180
    @bhandras
    bhandras committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    892561f View commit details
    Browse the repository at this point in the history

  3. docs: update release notes for 0.18.2-beta

    @bhandras
    bhandras committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    b35f060 View commit details
    Browse the repository at this point in the history