-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lncli openchannel fix #8934
base: master
Are you sure you want to change the base?
lncli openchannel fix #8934
Conversation
For the non-blocking case we use the the synchronous channel opening call now.
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ff5a2ed
to
31f0bd2
Compare
31f0bd2
to
e61d1ea
Compare
e61d1ea
to
0aadb3e
Compare
@yyforyongyu: review reminder |
!lightninglabs-deploy mute |
A minor fix which resulted from #8896.
Basically when opening a channel in the non-blocking case we would still keep a goroutine open on the LND server side although the
lncli
part would already have been exited after the funding transaction was broadcasted to the mempool. For this case we should use the OpenChannelSync API rather than the async call.I verified the behavior on regtest and we would indeed keep a goroutine until the channel reached its
MinDepthHeight
.EDIT: Moreover we add a itest for the OpenChannelSync cmd.