-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnwallet: fix panic on aux sig handling #9120
lnwallet: fix panic on aux sig handling #9120
Conversation
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -5553,7 +5553,10 @@ func genHtlcSigValidationJobs(chanState *channeldb.OpenChannel, | |||
// disk later. | |||
sigType := htlcCustomSigType.TypeVal() | |||
auxSig.WhenSome(func(sigB tlv.Blob) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This panic behavior was exposed on this litd itest
Not sure if I should do the nil check, as is now, or if I should instead correctly initialize the map.
This current diff seems to be satisfying for the itest linked above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should initialize the map correctly instead. Interestingly I ran into the same thing in part 3 of the rebased series today. I did the initialization on nil there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it looks in master now:
if htlc.CustomRecords == nil {
htlc.CustomRecords = make(lnwire.CustomRecords)
}
See 83fdbda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Though since this will be nil
in most cases, this will prevent us from setting the sigs correctly. We instead need to initialize the map when necessary.
@@ -5553,7 +5553,10 @@ func genHtlcSigValidationJobs(chanState *channeldb.OpenChannel, | |||
// disk later. | |||
sigType := htlcCustomSigType.TypeVal() | |||
auxSig.WhenSome(func(sigB tlv.Blob) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it looks in master now:
if htlc.CustomRecords == nil {
htlc.CustomRecords = make(lnwire.CustomRecords)
}
See 83fdbda
b027cb4
to
70338e3
Compare
d3267f3
into
lightningnetwork:0-19-staging
Fixes a panic caused by sending regular payments over a custom channel, in which case the
htlc.CustomRecords
map would be uninitialized.