-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
channeldb/mig/lnwire21: fix FailInvalidBlinding Encode sig #9161
channeldb/mig/lnwire21: fix FailInvalidBlinding Encode sig #9161
Conversation
fix the signature of the Encode method so that it does in fact implement the Serializable interface defined in the lnwire21 package. This differs slightly from the interface defined in the main lnwire package.
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch 👍
Hmm I wonder why the migration did not crash when the serialize method was called for the FailInvalidBlinding
?
I wonder if we can establish a better method for testing migrations. Because of the incompatibility when reverting to a lower version, I think this bears significant risk cc @saubyk
It silently fails due to the type not being matched:
|
Fix the signature of the Encode method so that it does in fact
implement the Serializable interface defined in the lnwire21
package. This differs slightly from the interface defined in the
main lnwire package.
The issue was introduced in this commit which copied over the FailInvalidBlinding type over from lnwire to lnwire21. The issue was that the Serializable interface in lnwire differs slightly from the Serializable interface in lnwire21.
No change log since this fixes a migration that is only in master.
Fixes #9160