Refactored StickyPartitionAssignmentStrategy and implemented task estimation logic in LoadBasedPartitionAssignmentStrategy #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onThroughput provider instead
vmaheshw
reviewed
Jun 11, 2021
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/linkedin/datastream/server/assignment/StickyPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...main/java/com/linkedin/datastream/server/providers/FileBasedPartitionThroughputProvider.java
Show resolved
Hide resolved
...java/com/linkedin/datastream/server/assignment/TestLoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
vmaheshw
reviewed
Jun 15, 2021
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/linkedin/datastream/server/assignment/StickyPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/linkedin/datastream/server/assignment/StickyPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/linkedin/datastream/server/assignment/StickyPartitionAssignmentStrategy.java
Show resolved
Hide resolved
...java/com/linkedin/datastream/server/assignment/TestLoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/datastream/server/assignment/TestLoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
...java/com/linkedin/datastream/server/assignment/TestLoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
...java/com/linkedin/datastream/server/assignment/TestLoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
vmaheshw
reviewed
Jun 15, 2021
...c/main/java/com/linkedin/datastream/server/assignment/StickyPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/datastream/server/assignment/TestLoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
...java/com/linkedin/datastream/server/assignment/TestLoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
vmaheshw
previously approved these changes
Jun 16, 2021
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/datastream/server/assignment/TestLoadBasedPartitionAssignmentStrategy.java
Show resolved
Hide resolved
vmaheshw
approved these changes
Jun 16, 2021
shrinandthakkar
approved these changes
Jun 17, 2021
vmaheshw
pushed a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
…imation logic in LoadBasedPartitionAssignmentStrategy (linkedin#835)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatastreamClusterResolverand refactoredThroughputInfoProvider. Now it's up toThroughputInfoProviderto find source Kafka cluster and source fabric.StickyPartitionAssignmentStrategyto break down the task count validation method into a method which just retrieves the task count estimate and a second one which does the validation and throws the exception._isPartitionNumBasedTaskCountEstimationEnabledand_isThroughputBasedTaskCountEstimationEnabledto be able to toggle them individually. These will be converted to proper configs in one the next PRs.LoadBasedPartitionAssignmentStrategy.LoadBasedPartitionAssignmentStrategyImportant: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md