Make Default byte in rate and Msg in rate configurable #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull latest
...va/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategyConfig.java
Outdated
Show resolved
Hide resolved
shrinandthakkar
previously approved these changes
Nov 5, 2021
added 2 commits
November 5, 2021 17:27
…oklin into fixDefaultPartitionByteRate
shrinandthakkar
approved these changes
Nov 8, 2021
vmaheshw
added a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
The default values set may need to be changed based on the specific scenario. Specifically, this brings a dependency that if the default throughput rate per task in 5MB and the default is 5KB, it implies that a task can only process 1000 partitions. Making this a configurable property will make it customizable based on the requirement. Note: This change does not cover config at a datastream level. We can add it based on the requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default values set may need to be changed based on the specific scenario. Specifically, this brings a dependency that if the default throughput rate per task in 5MB and the default is 5KB, it implies that a task can only process 1000 partitions. Making this a configurable property will make it customizable based on the requirement.
Note: This change does not cover config at a datastream level. We can add it based on the requirement.