Fix the metrics deregistration in AbstractKafkaConnector when multiple stop are called #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull latest
…e stop are called
surajkn
approved these changes
Nov 5, 2021
jzakaryan
approved these changes
Nov 5, 2021
vmaheshw
added a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
…e stop are called (linkedin#865) Metric registration and deregistration are ref counted. For aggregate metrics, all the tasks share the same metric object. If the ref-count gets to zero, the metric Register class removes the metrics and on next registration, creates a new metric object that will be emitted outside the container. So, if there are more de-registration than the registration, some of the live running tasks will point to a metric object, that no longer exists in Metric Registry, resulting in incorrect Aggregate metrics. This PR addresses and fixes that deregistration of metrics should happen only once per task thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metric registration and deregistration are ref counted. For aggregate metrics, all the tasks share the same metric object. If the ref-count gets to zero, the metric Register class removes the metrics and on next registration, creates a new metric object that will be emitted outside the container. So, if there are more de-registration than the registration, some of the live running tasks will point to a metric object, that no longer exists in Metric Registry, resulting in incorrect Aggregate metrics.
This PR addresses and fixes that deregistration of metrics should happen only once per task thread.