Dedupe tasks on LeaderDoAssignment #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinandthakkar
requested changes
May 10, 2022
datastream-server/src/main/java/com/linkedin/datastream/server/zk/ZkAdapter.java
Outdated
Show resolved
Hide resolved
shrinandthakkar
requested changes
May 25, 2022
...am-server/src/main/java/com/linkedin/datastream/server/assignment/LoadbalancingStrategy.java
Show resolved
Hide resolved
vmaheshw
reviewed
May 25, 2022
...stream-server/src/main/java/com/linkedin/datastream/server/assignment/BroadcastStrategy.java
Outdated
Show resolved
Hide resolved
...am-server/src/main/java/com/linkedin/datastream/server/assignment/LoadbalancingStrategy.java
Outdated
Show resolved
Hide resolved
vmaheshw
reviewed
Jun 2, 2022
...stream-server/src/main/java/com/linkedin/datastream/server/assignment/BroadcastStrategy.java
Show resolved
Hide resolved
vmaheshw
approved these changes
Jun 6, 2022
shrinandthakkar
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crashing during
LeaderDoAssignmentby deduplicating tasks that contain the same task name.This can happen if a leader change happens while saving an existing assignment change is already in progress.
If we reach this case, select one of the tasks as valid and remove the others.