Safely handle records without ResourceRecords

Always check the length of ResourceRecords before trying to index. Fix #87
linki · Feb 24, 2017 · fbdce6b · fbdce6b
1 parent c1eda17
commit fbdce6b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/consumers/aws.go b/consumers/aws.go
@@ -265,7 +265,7 @@ func (a *awsConsumer) recordInfo(records []*route53.ResourceRecordSet) map[strin
 	groupIDMap := map[string]string{} //maps dns to group ID
 
 	for _, record := range records {
-		if (aws.StringValue(record.Type)) == "TXT" {
+		if aws.StringValue(record.Type) == "TXT" && len(record.ResourceRecords) > 0 {
 			groupIDMap[aws.StringValue(record.Name)] = aws.StringValue(record.ResourceRecords[0].Value)
 		} else {
 			if _, exist := groupIDMap[aws.StringValue(record.Name)]; !exist {

diff --git a/consumers/aws_test.go b/consumers/aws_test.go
@@ -150,6 +150,11 @@ func TestRecordInfo(t *testing.T) {
 				},
 			},
 		},
+		&route53.ResourceRecordSet{
+			Type:            aws.String("TXT"),
+			Name:            aws.String("test.example.com."),
+			ResourceRecords: nil,
+		},
 	}
 	recordInfoMap := client.recordInfo(records)
 	if len(recordInfoMap) != 1 {