release: v1.41.1

liriliri · Jul 23, 2024 · 8c0c90d · 8c0c90d
1 parent 4cacaaf
commit 8c0c90d
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## v1.41.1 (23 Jul 2024)
+
+* fix: randomId size over 21 error [#33](https://github.com/liriliri/licia/issues/33)
+
 ## v1.41.0 (18 Jun 2024)
 
 * feat: add dataUrl

diff --git a/lib/update.js b/lib/update.js
@@ -10,7 +10,6 @@ const {
     map,
     contain,
     sortKeys,
-    escape,
     filter,
     concat,
     unique

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "licia",
-  "version": "1.41.0",
+  "version": "1.41.1",
   "description": "Useful utility collection with zero dependencies",
   "bin": {
     "licia": "./bin/licia.js"

diff --git a/src/randomId.js b/src/randomId.js
@@ -30,7 +30,7 @@ exports = function(size = 21, symbols = defSymbols) {
     let id = '';
 
     const len = symbols.length;
-    const bytes = randomBytes(21);
+    const bytes = randomBytes(size);
     while (0 < size--) {
         id += symbols[bytes[size] % len];
     }

diff --git a/test/randomId.js b/test/randomId.js
@@ -2,3 +2,4 @@ expect(randomId()).to.be.a('string');
 expect(randomId().length).to.equal(21);
 expect(randomId(12).length).to.equal(12);
 expect(randomId(5, 'a')).to.equal('aaaaa');
+expect(randomId(22, 'a')).to.equal('aaaaaaaaaaaaaaaaaaaaaa');