Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][test] support.limits.general/.version.compile.pass.cpp is malformed #75577

Closed
StephanTLavavej opened this issue Dec 15, 2023 · 3 comments · Fixed by #75699
Closed

[libc++][test] support.limits.general/.version.compile.pass.cpp is malformed #75577

StephanTLavavej opened this issue Dec 15, 2023 · 3 comments · Fixed by #75699
Assignees
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. test-suite

Comments

@StephanTLavavej
Copy link
Member

This file's name and contents are bogus:

// WARNING: This test was generated by generate_feature_test_macro_components.py
// and should not be edited manually.
//
// clang-format off
// <>
// Test the feature test macros defined by <>
/* Constant Value
__cpp_lib_format_uchar 202311L [C++20]
__cpp_lib_saturation_arithmetic 202311L [C++26]
*/
#include <>
#include "test_macros.h"

I suspect that lit is skipping this because it doesn't recognize the filename, which is why neither llvm/llvm-project nor microsoft/STL noticed this. However, MSVC's internal test harness is far less enlightened and tried to run everything, which brought this to my attention.

@mordante This appears to have been introduced by #72421.

@github-actions github-actions bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Dec 15, 2023
@mordante mordante self-assigned this Dec 15, 2023
@mordante
Copy link
Member

I had a look and I guess it's due to some FTM didn't specified the affected headers so I left them empty.
(Look at what is merged in the WP is on my TODO list.)

@frederick-vs-ja
Copy link
Contributor

IIUC the contents should moved into format.version.compile.pass.cpp and numeric.version.compile.pass.cpp.

mordante added a commit to mordante/llvm-project that referenced this issue Dec 16, 2023
These feature-test macros had no headers listed in their associated
papers. This adds the expected headers.

Fixes llvm#75577
@mordante
Copy link
Member

IIUC the contents should moved into format.version.compile.pass.cpp and numeric.version.compile.pass.cpp.

That's indeed what has been done in the PR's for the Standard. The papers in question didn't mention the affected headers.

philnik777 pushed a commit that referenced this issue Dec 18, 2023
These feature-test macros had no headers listed in their associated
papers. This adds the expected headers.

Fixes #75577
blueboxd pushed a commit to blueboxd/libcxx that referenced this issue Feb 1, 2024
These feature-test macros had no headers listed in their associated
papers. This adds the expected headers.

Fixes llvm/llvm-project#75577

NOKEYCHECK=True
GitOrigin-RevId: 9c18f031968aabc7698e9ab0ea94da3b665d4d5a
qihangkong pushed a commit to rvgpu/rvgpu-llvm that referenced this issue Apr 23, 2024
These feature-test macros had no headers listed in their associated
papers. This adds the expected headers.

Fixes llvm/llvm-project#75577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. test-suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants