-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] Reduce size of FunctionEffect to 1 byte. #100753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Clang issues not falling into any other category
clang:frontend
Language frontend issues, e.g. anything involving "Sema"
labels
Jul 26, 2024
@llvm/pr-subscribers-clang Author: Doug Wyatt (dougsonos) ChangesAs a preliminary to PR #99656 , reduce the size of Full diff: https://github.com/llvm/llvm-project/pull/100753.diff 1 Files Affected:
diff --git a/clang/include/clang/AST/Type.h b/clang/include/clang/AST/Type.h
index 25defea58c2dc..cb345c3028909 100644
--- a/clang/include/clang/AST/Type.h
+++ b/clang/include/clang/AST/Type.h
@@ -4699,16 +4699,16 @@ class FunctionEffect {
private:
LLVM_PREFERRED_TYPE(Kind)
- unsigned FKind : 3;
+ uint8_t FKind : 3;
// Expansion: for hypothetical TCB+types, there could be one Kind for TCB,
// then ~16(?) bits "SubKind" to map to a specific named TCB. SubKind would
// be considered for uniqueness.
public:
- FunctionEffect() : FKind(unsigned(Kind::None)) {}
+ FunctionEffect() : FKind(uint8_t(Kind::None)) {}
- explicit FunctionEffect(Kind K) : FKind(unsigned(K)) {}
+ explicit FunctionEffect(Kind K) : FKind(uint8_t(K)) {}
/// The kind of the effect.
Kind kind() const { return Kind(FKind); }
|
Sirraide
reviewed
Jul 26, 2024
Sirraide
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cor3ntin
approved these changes
Jul 26, 2024
jroelofs
approved these changes
Jul 26, 2024
dougsonos
pushed a commit
to dougsonos/llvm-project
that referenced
this pull request
Aug 2, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 22, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 22, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 22, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 22, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 23, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 23, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 26, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 26, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 26, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 26, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 27, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
cjappl
pushed a commit
to cjappl/llvm-project
that referenced
this pull request
Aug 27, 2024
Make FunctionEffect just have a Kind instead of a bitfield (from PR llvm#100753)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
clang:frontend
Language frontend issues, e.g. anything involving "Sema"
clang
Clang issues not falling into any other category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preliminary to PR #99656 , reduce the size of
FunctionEffect
to 1 byte.