Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Add labels on pull requests based on paths. #65308

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

cor3ntin
Copy link
Contributor

@cor3ntin cor3ntin commented Sep 5, 2023

Using https://github.com/actions/labeler, this add a workflow to automatically label PRs, in hope to reduce the work needed to triage new PRs.

"new-prs-labeler.yml" has been seeded taking inspiration from the CODEOWNERS file when there was an existing corresponding label on the issue tracker.

@cor3ntin cor3ntin requested a review from a team as a code owner September 5, 2023 09:07
@cor3ntin cor3ntin requested review from Endilll and asl September 5, 2023 09:08
@cor3ntin
Copy link
Contributor Author

cor3ntin commented Sep 5, 2023

Obviously the provided rules are far from complete, but that seems sufficient to seed the effort and other people can all labels as they see fit.

This has not been tested, not sure how testing that sort of change can be done.

@tru
Copy link
Collaborator

tru commented Sep 5, 2023

This has not been tested, not sure how testing that sort of change can be done.

Push to your fork and open a PR towards your fork instead of main.

This looks fine to me. It's a shame that we can't use the same mapping as CODEOWNERS since this means we will have to dupe the "rules" in both places. But I still think it is worth doing.

.github/workflows/new-prs-labeler.yml Outdated Show resolved Hide resolved
Using https://github.com/actions/labeler, this add a workflow
to automatically label PRs, in hope to reduce the work needed to triage
new PRs.

"new-prs-labeler.yml" has been seeded taking inspiration
from the CODEOWNERS file when there was an existing corresponding
label on the issue tracker.
@cor3ntin cor3ntin merged commit d17e6cc into llvm:main Sep 5, 2023
1 check passed
@cor3ntin cor3ntin deleted the label_prs branch September 5, 2023 13:26
Copy link
Collaborator

@tstellar tstellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some way we can pull all the path information from the CODEOWNERS file? It doesn't seem great to have this information duplicated in two places.

@cor3ntin
Copy link
Contributor Author

cor3ntin commented Sep 5, 2023

Sadly no, first because the labeler does not support it, and there isn't a perfect match between the labels and the teams

avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
Using https://github.com/actions/labeler, this add a workflow to
automatically label PRs, in hope to reduce the work needed to triage new
PRs.

"new-prs-labeler.yml" has been seeded taking inspiration from the
CODEOWNERS file when there was an existing corresponding label on the
issue tracker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants