fix(pro): delete ownded workspace #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pro provider attempts to delete the CRD instead of calling the workspace instances `/delete` endpoint on the runner. This allows us to hook into the ownership mechanism without granting all project users access to the `devpodworkspaceinstances/delete` subresource. In effect this allows all project users to delete their own workspaces but not others. Admins can still delete all workspaces
janekbaraniewski
approved these changes
Aug 20, 2024
bkneis
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pro provider attempts to delete the CRD instead of calling the
workspace instances
/deleteendpoint on the runner.This allows us to hook into the ownership mechanism without granting all
project users access to the
devpodworkspaceinstances/deletesubresource.
In effect this allows all project users to delete their own workspaces
but not others. Admins can still delete all workspaces