Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log and wrap error when setting up loft platform #1266

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

bkneis
Copy link
Contributor

@bkneis bkneis commented Sep 17, 2024

A user reported an error setting up the loft platform

https://app.usepylon.com/issues?conversationID=4a04f1ed-4a71-47e9-8b15-46edea30fdb3

Unfortunately, we didn't log or return the error so it is difficult to debug. This PR addresses the problem by wrapping the platform error and returning it.

NOTE: Is returning the error correct? I was unsure on expected behaviour, if we can't get the executable or port number we seem to return the error. But if the loft platform access error'd then we simply logged it. If we should NOT return the error I can update the PR to simply log the wrapped error.

UPDATE: I removed returning the error as this could cause more trouble than solve until we know why the bellow happens.

UPDATE: I reproduced the error locally by simply running devpod up https://github.com/microsoft/vscode-remote-try-go

08:26:38 error failure in setting up Loft Platform access: 08:26:38 info 07:26:37 fatal unknown flag: --port
08:26:38 fatal inner tunnel: Process exited with status 1

These are the resulting logs. I SSH'd onto the workspace and found that the entire setup-loft-access command was missing from devpod agent container.

@janekbaraniewski can you see any way that the command would not be present? I thought we scp'd the devpod binary over the container, it's odd my local devpod had the command but on the workspace not.

@janekbaraniewski
Copy link
Contributor

LGTM, as long as there is no reason we didn't error there in the first place 😅

@pascalbreuninger pascalbreuninger merged commit abb49c6 into loft-sh:main Sep 25, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants