Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/POD 884 docker credential forwarding #1282

Conversation

pascalbreuninger
Copy link
Member

@pascalbreuninger pascalbreuninger commented Sep 25, 2024

feat(cli): merge devpod context option from environment in proxy mode.
This allows us to set context options on the remote side and have devpod xxx commands read them. Remote context settings take precedence over client settings.

  • feat(pro): add remote runner credentials server
    Adds a new type of gRPC server, RunnerServer, which is directly connected to every workspace created through Pro.
    This allows admins to overwrite settings in the credentials easily.
image

When running `up` or `ssh` from Pro (=in proxy mode) we merge the pro
environments context options with the existing options.
@pascalbreuninger pascalbreuninger force-pushed the feat/POD-884-docker-credential-forwarding branch 3 times, most recently from 3cfcf4a to 58fe2e7 Compare September 26, 2024 07:51
cmd/agent/container/credentials_server.go Show resolved Hide resolved
cmd/ssh.go Show resolved Hide resolved
cmd/ssh.go Show resolved Hide resolved
cmd/up.go Outdated Show resolved Hide resolved
@pascalbreuninger pascalbreuninger force-pushed the feat/POD-884-docker-credential-forwarding branch 2 times, most recently from d785c5a to 94eb4ad Compare September 27, 2024 07:36
@pascalbreuninger pascalbreuninger force-pushed the feat/POD-884-docker-credential-forwarding branch from 94eb4ad to e4a7c92 Compare September 27, 2024 07:37
@pascalbreuninger pascalbreuninger merged commit 4ec4ff2 into loft-sh:main Sep 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants