[enhancement] added hidden flag to override number of virtual cluster

restriction
loft-sh · Aug 14, 2024 · f62193f · f62193f
1 parent fb5034c
commit f62193f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/cmd/vclusterctl/cmd/create.go b/cmd/vclusterctl/cmd/create.go
@@ -21,7 +21,8 @@ type CreateCmd struct {
 	*flags.GlobalFlags
 	cli.CreateOptions
 
-	log log.Logger
+	log            log.Logger
+	reuseNamespace bool
 }
 
 // NewCreateCmd creates a new command
@@ -53,6 +54,8 @@ vcluster create test --namespace test
 	}
 
 	cobraCmd.Flags().StringVar(&cmd.Driver, "driver", "", "The driver to use for managing the virtual cluster, can be either helm or platform.")
+	cobraCmd.Flags().BoolVar(&cmd.reuseNamespace, "reuse-namespace", false, "Allows to create multiple virtual clusters in a single namespace")
+	cobraCmd.Flag("reuse-namespace").Hidden = true
 
 	create.AddCommonFlags(cobraCmd, &cmd.CreateOptions)
 	create.AddHelmFlags(cobraCmd, &cmd.CreateOptions)
@@ -82,5 +85,5 @@ func (cmd *CreateCmd) Run(ctx context.Context, args []string) error {
 		return cli.CreatePlatform(ctx, &cmd.CreateOptions, cmd.GlobalFlags, args[0], cmd.log)
 	}
 
-	return cli.CreateHelm(ctx, &cmd.CreateOptions, cmd.GlobalFlags, args[0], cmd.log)
+	return cli.CreateHelm(ctx, &cmd.CreateOptions, cmd.GlobalFlags, args[0], cmd.log, cmd.reuseNamespace)
 }
diff --git a/pkg/cli/create_helm.go b/pkg/cli/create_helm.go
@@ -102,7 +102,7 @@ type createHelm struct {
 	localCluster     bool
 }
 
-func CreateHelm(ctx context.Context, options *CreateOptions, globalFlags *flags.GlobalFlags, vClusterName string, log log.Logger) error {
+func CreateHelm(ctx context.Context, options *CreateOptions, globalFlags *flags.GlobalFlags, vClusterName string, log log.Logger, reuseNamespace bool) error {
 	cmd := &createHelm{
 		GlobalFlags:   globalFlags,
 		CreateOptions: options,
@@ -134,9 +134,12 @@ func CreateHelm(ctx context.Context, options *CreateOptions, globalFlags *flags.
 	if err != nil {
 		return err
 	}
-	for _, v := range vclusters {
-		if v.Namespace == cmd.Namespace && v.Name != vClusterName {
-			return fmt.Errorf("there is already a virtual cluster in namespace %s", cmd.Namespace)
+
+	if !reuseNamespace {
+		for _, v := range vclusters {
+			if v.Namespace == cmd.Namespace && v.Name != vClusterName {
+				return fmt.Errorf("there is already a virtual cluster in namespace %s", cmd.Namespace)
+			}
 		}
 	}