chore: validate passed in values files before passing it to helm #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
johannesfrey
requested review from
FabianKramm,
ThomasK33 and
heiko-braun
and removed request for
FabianKramm
ThomasK33
reviewed
Apr 12, 2024
ThomasK33
reviewed
Apr 12, 2024
johannesfrey
force-pushed
the
vcluster-create-config-validation
branch
2 times, most recently
from
1aedd22
to
030a2ab
Compare
johannesfrey
force-pushed
the
vcluster-create-config-validation
branch
from
030a2ab
to
dbf1462
Compare
ThomasK33
reviewed
Apr 12, 2024
Co-authored-by: Thomas Kosiewski <thoma471@googlemail.com>
ThomasK33
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Resolves ENG-3334
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster would pass the values file to
helm installwithout validating them beforehand.What else do we need to know?