Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show a message if user attempts to use pro / platform features #1677

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

lizardruss
Copy link
Contributor

@lizardruss lizardruss commented Apr 12, 2024

What issue type does this pull request address?
/kind enhancement

What does this pull request do? Which issues does it resolve?
resolves ENG-3327

Please provide a short message that should be published in the vcluster release notes
Log a message if user attempt to use a pro feature before supported

What else do we need to know?
Currently logs a message any time any pro feature is enabled, but an additional way to disable the check may be desired.

Also adds missing pro attributes for schema partials generation.

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit 75e98ff
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/661cedfef0560c00081eb2ea

@FabianKramm FabianKramm marked this pull request as ready for review April 15, 2024 08:44
@FabianKramm FabianKramm merged commit 4a2018c into main Apr 15, 2024
73 checks passed
@heiko-braun
Copy link
Contributor

Fabians latest changes in essence add an ENV VAR that allow to override the checks Russ has put into place:

func ShouldCheckForProFeatures() bool {
	return os.Getenv("FORCE_VCLUSTER_PRO") != "true"
}

@ThomasK33 ThomasK33 deleted the ENG-3327 branch June 3, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants