refactor: introduce vCluster manager #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
FabianKramm
force-pushed
the
refactor
branch
2 times, most recently
from
5a2b38b
to
2977ac4
Compare
FabianKramm
force-pushed
the
refactor
branch
3 times, most recently
from
b3d892e
to
ce015cf
Compare
FabianKramm
force-pushed
the
refactor
branch
2 times, most recently
from
f10823a
to
c3f828d
Compare
|
Do we keep |
|
@heiko-braun yes, why shouldn't we? |
FabianKramm
force-pushed
the
refactor
branch
5 times, most recently
from
88dc92d
to
ef8174c
Compare
ThomasK33
reviewed
Apr 22, 2024
FabianKramm
force-pushed
the
refactor
branch
8 times, most recently
from
6deaf5e
to
d8a7fe8
Compare
johannesfrey
approved these changes
Apr 23, 2024
ThomasK33
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Resolves ENG-3491
Resolves ENG-3493
Changes:
vcluster use manager helm|platformcommandvcluster create,vcluster connect,vcluster list,vcluster pause,vcluster resume&vcluster deletevcluster import->vcluster activatevcluster pro->vcluster platformvcluster pro generate admin-kube-configplatform.apiKey->platform.apicmd/vclusterctl/cmdtopkg/clipkg/config/legacyconfig->config/legacyconfig