fix/refactor: remove need to pass cli.Config to subcommands #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
rohantmp
commented
May 31, 2024
|
This will probably need a last minute rebase again even if I rebase now given the files it touches. Let me know when reviewing and I'll do it then :) |
rohantmp
force-pushed
the
fixAddCluster
branch
2 times, most recently
from
5d8e2db
to
18a0cf4
Compare
johannesfrey
approved these changes
May 31, 2024
earlier, `vcluster platform add cluster` had an unintialized config Signed-off-by: Rohan CJ <rohantmp@gmail.com>
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
ThomasK33
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier,
vcluster platform add clusterhad an uninitialized config.I think generating from GlobalFlags reduces the need to drill down another var
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix