[enhancement] now refuses to create multiple virtual clusters in same ns #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
facchettos
force-pushed
the
refuse-multiple-vcluster-in-ns
branch
from
30fe6c3
to
78e2396
Compare
facchettos
force-pushed
the
refuse-multiple-vcluster-in-ns
branch
from
78e2396
to
8b683e1
Compare
johannesfrey
approved these changes
Aug 9, 2024
facchettos
force-pushed
the
refuse-multiple-vcluster-in-ns
branch
from
8b683e1
to
6d13723
Compare
FabianKramm
reviewed
Aug 12, 2024
cmd/vclusterctl/cmd/create.go
Outdated
| if v.Namespace == cmd.Namespace && v.Name != args[0] { | ||
| return fmt.Errorf("there is already a virtual cluster in namespace %s", cmd.Namespace) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this should go into the helm driver only, as there can be many vClusters with the same namespace in the platform in different host clusters
There was a problem hiding this comment.
I had it there before, but do we support creating multiple virtual clusters in the same ns with the platform?
There was a problem hiding this comment.
it seems that the ListOSS function should work with platform created virtual clusters too, since it's fetching the statefulset/deployment
facchettos
force-pushed
the
refuse-multiple-vcluster-in-ns
branch
from
8a452e9
to
6d13723
Compare
FabianKramm
reviewed
Aug 12, 2024
FabianKramm
approved these changes
Aug 12, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Aug 13, 2024
[v0.20] [enhancement] now refuses to create multiple virtual clusters in same ns (#2052)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves eng-4308
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster would let users create multiple virtual clusters in the same ns
What else do we need to know?