Adds min and max to LimitRange #2088
Merged
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
|
@emoreth thanks for creating this PR! With the current implementation this won't have any effect, are you sure this PR is complete since there are no chart changes. |
emoreth
force-pushed
the
adds_min_and_max_to_limitrange
branch
from
32fe9c1
to
b06bfd4
Compare
|
Sorry, I missed pushing a file 🤦 |
emoreth
force-pushed
the
adds_min_and_max_to_limitrange
branch
from
b06bfd4
to
3e3db22
Compare
|
@emoreth thanks for that, you will also need to add that to the |
emoreth
force-pushed
the
adds_min_and_max_to_limitrange
branch
from
736f716
to
efa2545
Compare
|
@FabianKramm Sorry for the @, but this should be a quick one |
FabianKramm
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
@emoreth thanks again! LGTM! Sorry for letting this hang so long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)The LimitRange resource lacks options for
minandmax.Please provide a short message that should be published in the vcluster release notes
Add min and max options to LimitRange
What else do we need to know?