Check if vcluster chart version supports k8s version #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior, an extra value, distro.k8s.version, could be set for a vcluster with a version that does not support the distro.k8s.version field. This would lead to a panic in vcluster. Now, the value is only set if the vcluster chart version is known to support it. Otherwise, it is left empty, leading to the omission of the field and no panic. fix
✅ Deploy Preview for vcluster-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
FabianKramm
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Fixes ENG-4480
Prior, an extra value, distro.k8s.version, could be set for a vcluster with a version that does not support the distro.k8s.version field. This would lead to a panic in vcluster. Now, the value is only set if the vcluster chart version is known to support it. Otherwise, it is left empty, leading to the omission of the field and no panic.
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where older vcluster versions may panic due to being passed an unsupported value.
What else do we need to know?