Captures helm error before trying to call WaitForReadyLoftPod #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
andyluak
approved these changes
Sep 17, 2024
ThomasK33
reviewed
Sep 17, 2024
|
Yeah why is that running in parallel at all? |
FabianKramm
approved these changes
Sep 18, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
lizardruss
added a commit
that referenced
this pull request
Sep 19, 2024
[v0.20] Merge pull request #2148 from zerbitx/ENG-4585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #ENG-4585
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where if the helm command to add a cluster failed, the error wouldn't be reported quickly because waiting for the pod began before the helm error was checked.