feat(core): init basic sentinel #4554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/sentinel/basic-sentinel.test.ts | 📈 +3.87 KB |
| packages/core/src/sentinel/basic-sentinel.ts | 📈 +5.02 KB |
| packages/core/src/test-utils/query.ts | 📈 +566 Bytes |
| packages/schemas/src/types/sentinel.ts | 📈 +149 Bytes |
gao-sun
force-pushed
the
gao-basic-sentinel
branch
from
5a47186
to
b9ab1f3
Compare
wangsijie
approved these changes
Sep 22, 2023
darcyYe
approved these changes
Sep 22, 2023
gao-sun
force-pushed
the
gao-basic-sentinel
branch
from
e62a8ac
to
691f31e
Compare
gao-sun
force-pushed
the
gao-basic-sentinel
branch
from
691f31e
to
24f70eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
implement a basic sentinel that blocks a user after 5 failed attempts in 1 hour. the definition of "attempt" including both verification code and password submission.
Testing
unit tests
Checklist
.changesetintegration tests(not this PR)docs(not this PR)