fix(core): add hasPassword field to user API response
#6543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyijun
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/polite-bats-learn.md | 📈 +80 Bytes |
| packages/core/src/mocks/user.ts | 📈 +5 Bytes |
| packages/core/src/routes/admin-user/basics.ts | 📈 +31 Bytes |
| packages/core/src/routes/admin-user/search.test.ts | 📈 +40 Bytes |
| packages/core/src/routes/admin-user/search.ts | 📈 +30 Bytes |
| packages/core/src/routes/admin-user/social.ts | 📈 +37 Bytes |
| packages/core/src/routes/role.user.ts | 📈 +37 Bytes |
| packages/core/src/utils/user.ts | 📈 +1.08 KB |
| packages/integration-tests/src/helpers/user.ts | 📈 +60 Bytes |
| packages/integration-tests/src/tests/api/admin-user.test.ts | 📈 +119 Bytes |
| packages/integration-tests/src/tests/api/organization/organization-user.test.ts | 📈 +484 Bytes |
xiaoyijun
force-pushed
the
xiaoyijun-core-return-has-password-value
branch
from
c1eb42c
to
32ac855
Compare
wangsijie
approved these changes
Sep 4, 2024
gao-sun
approved these changes
Sep 4, 2024
xiaoyijun
force-pushed
the
xiaoyijun-core-return-has-password-value
branch
from
32ac855
to
c49c325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the original implementation,
hasPasswordfield is mentioned in the API doc, but missing in API response.This PR fix this issue.
Testing
Test locally and all UT & IT passed.
Checklist
.changeset