Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schemas): add verification record table #6566

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

wangsijie
Copy link
Contributor

@wangsijie wangsijie commented Sep 10, 2024

Summary

Add verification_records table, this table will be used to store verification records, and we'll migrate the VerificationRecord in experience API to use this table as well.

The type of data is intended to set to JsonObject, this can avoid complex typing. Because this field can not be used directly, it must be parsed according to the type, and to be used to rebuild verification class.

Testing

N/A

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Sep 10, 2024

COMPARE TO master

Total Size Diff 📈 +1.78 KB

Diff by File
Name Diff
packages/schemas/alterations/next-1725971571-add-verification-record.ts 📈 +1.1 KB
packages/schemas/src/foundations/jsonb-types/index.ts 📈 +43 Bytes
packages/schemas/src/foundations/jsonb-types/verification-records.ts 📈 +430 Bytes
packages/schemas/src/types/interactions.ts 📈 +390 Bytes
packages/schemas/src/types/log/interaction.ts 📈 +5 Bytes
packages/schemas/tables/verification_records.sql 📈 +606 Bytes

@github-actions github-actions bot added feature Cool stuff size/s labels Sep 10, 2024
@wangsijie wangsijie force-pushed the wangsijie-log-9934-init-verification-table branch from 86e5a07 to 6573de3 Compare September 10, 2024 12:36
@github-actions github-actions bot added size/m and removed size/s labels Sep 10, 2024
@wangsijie wangsijie force-pushed the wangsijie-log-9934-init-verification-table branch from 6573de3 to 9fd6b5e Compare September 10, 2024 13:21
@wangsijie wangsijie force-pushed the wangsijie-log-9934-init-verification-table branch from 9fd6b5e to 28b6296 Compare September 12, 2024 05:27
@github-actions github-actions bot added size/s and removed size/m labels Sep 12, 2024
@wangsijie wangsijie force-pushed the wangsijie-log-9934-init-verification-table branch 2 times, most recently from f1ea3d5 to eb6ebd5 Compare September 12, 2024 07:59
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangsijie wangsijie force-pushed the wangsijie-log-9934-init-verification-table branch from eb6ebd5 to d0f259b Compare September 12, 2024 09:21
@wangsijie wangsijie merged commit 8bb5c81 into master Sep 13, 2024
29 checks passed
@wangsijie wangsijie deleted the wangsijie-log-9934-init-verification-table branch September 13, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants