Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom config file locations via environment variables #1987

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NorthIsUp
Copy link

@NorthIsUp NorthIsUp commented Jan 19, 2024

This adds support for a custom config file location via the new $MACKUP_CONFIG var or by checking for $XDG_CONFIG_HOME.

It searches for config files in the following order:

  • ~/.mackup.cfg
  • $MACKUP_CONFIG
  • $XDG_CONFIG_HOME/mackup/mackup.cfg
  • ~/.config/mackup/mackup.cfg

if none of these exist ~/.mackup.cfg is created and used

@NorthIsUp NorthIsUp changed the title add tests and changelog Support custom config file locations via environment variables Jan 19, 2024
@NorthIsUp NorthIsUp marked this pull request as ready for review January 19, 2024 20:01
@con-f-use
Copy link

con-f-use commented Feb 22, 2024

How has that not been merged yet? Seems like's been a very hot topic for a long time #473 #632 #1318 #1694 #1509 #1987

@NorthIsUp NorthIsUp force-pushed the adam/1-support_xdg_config_file_standard branch from 274b7e7 to 269e66a Compare February 26, 2024 17:35
@con-f-use
Copy link

pretty plz.

@lougreenwood
Copy link

Seems like a pretty straight forward & sensible PR for a long-requested feature. @lra any thoughts on this PR? Thanks! 🙏

@coquizen
Copy link

coquizen commented Jul 4, 2024

Agreed, this should be implemented. Those concerned with their config settings are often concerned with organizing where those config files are stored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants