Add handling of ESD files for Windows repacking #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: foxtrotcz <10333810+foxtrotcz@users.noreply.github.com>
stgraber
approved these changes
Sep 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #878
If it cant find WIM it tries ESD.
I also removed extension trimming in logging so there is difference between .wim and .esd
For now I only came across install.esd but I also added boot.esd check in case Microsoft starts packing it this way.
Repacking ISO with ESD takes longer because it has to deal with compression.
Installing Windows also works (tested in VM), maybe slower because of compression.