Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): add forbid_unsafe feature to disable unsafe code #413

Merged
merged 29 commits into from
Sep 13, 2024
Merged

feat(lib): add forbid_unsafe feature to disable unsafe code #413

merged 29 commits into from
Sep 13, 2024

Commits on Aug 18, 2024

  1. add default 'unsafe' feature, remove 'read_byte_unchecked'

    @davidkern
    davidkern committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    dc7b212 View commit details
    Browse the repository at this point in the history

  2. feature flag 'slice_unchecked'

    @davidkern
    davidkern committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    ef7e5ba View commit details
    Browse the repository at this point in the history

  3. feature flag remaining unsafety

    @davidkern
    davidkern committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    6ddaef9 View commit details
    Browse the repository at this point in the history

  4. fix misnamed feature flags

    @davidkern
    davidkern committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    c1ac617 View commit details
    Browse the repository at this point in the history

  5. fix a few more feature flags

    @davidkern
    davidkern committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    d4a6877 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. lints and formatting

    @davidkern
    davidkern committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    13cd8bc View commit details
    Browse the repository at this point in the history

  2. correct the auto-correct

    @davidkern
    davidkern committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    884d9ba View commit details
    Browse the repository at this point in the history

  3. Rename feature to forbid_unsafe so unsafe code is the default

    @davidkern
    davidkern committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    42e43be View commit details
    Browse the repository at this point in the history

  4. reintroduce 'read_byte_unchecked'

    @davidkern
    davidkern committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    223e3b5 View commit details
    Browse the repository at this point in the history

  5. don't use --all-features as the default, as that removes unsafe code … 

    …paths
    @davidkern
    davidkern committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ac3d019 View commit details
    Browse the repository at this point in the history

  6. add safe path to codegen and fix regression on unsafe path

    @davidkern
    davidkern committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7cd591a View commit details
    Browse the repository at this point in the history

  7. enable 'forbid_unsafe' on logos-derive/codegen if enabled on 'logos' … 

    …and macro is re-exported
    @davidkern
    davidkern committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f97c2d4 View commit details
    Browse the repository at this point in the history

  8. fmt

    @davidkern
    davidkern committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e2e5ed4 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. additionally run benchmarks against forbid_unsafe

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8c13adf View commit details
    Browse the repository at this point in the history

  2. add --features forbid_unsafe to the new benchmarks

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b4a2ceb View commit details
    Browse the repository at this point in the history

  3. handle case of base branch not supporting forbid_unsafe feature

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    40d2cab View commit details
    Browse the repository at this point in the history

  4. include comment if comparing against defaults instead of before

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0997c34 View commit details
    Browse the repository at this point in the history

  5. troubleshoot why the two benchmark runs seem to be the same

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    87ed40f View commit details
    Browse the repository at this point in the history

  6. try renaming the baselines

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c888fc1 View commit details
    Browse the repository at this point in the history

  7. seems baseline names may only include underscores

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c169614 View commit details
    Browse the repository at this point in the history

  8. and display the correct results for forbid_unsafe

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    fc950bf View commit details
    Browse the repository at this point in the history

  9. test default features and forbid unsafe in test matrix

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    af82cc9 View commit details
    Browse the repository at this point in the history

  10. add forbid_unsafe to integration test

    @davidkern
    davidkern committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a446f68 View commit details
    Browse the repository at this point in the history

  11. Feature forbid_unsafe tests and benchmarks

    @davidkern
    davidkern authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3a44e83 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. add safety note to source trait

    @davidkern
    davidkern committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d2ff9f5 View commit details
    Browse the repository at this point in the history

  2. add safety note to source trait

    @davidkern
    davidkern committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0242426 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. wordsmithing

    @davidkern
    davidkern committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7fcd8c6 View commit details
    Browse the repository at this point in the history

  2. include note on feature unification

    @davidkern
    davidkern committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    35a24bf View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. fmt

    @davidkern
    davidkern committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    45a3b68 View commit details
    Browse the repository at this point in the history