Form component container

[Jehangir-Wahid]

Adding documentation for the Container ui-component

This pull request (PR) is intended to add the Container ui-component's documentation to the ui-components list.

Affected DevDocs pages

This PR will add a new page to the ui-components. None of the pages will be affected by this PR.

whatsnew
Added a new topic for the Container ui-component.

[devops-devdocs]

An admin must run tests on this PR before it can be merged.

[ghost]

Hi @Jehangir-Wahid, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ghost]

Hi @Jehangir-Wahid, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[Jehangir-Wahid]

I have signed the Adobe CLA twice and it's check still requires signing it. What else am I supposed to do?

[rogyar]

Hi @Jehangir-Wahid. Thank you for the new topic. Please, check my comments below. Also, could I kindly ask you to provide the following information additionally, please?

• Add "whatsnew" section to the PR description with a sentence/two about the new information provided in this PR. You can check an example here
• Provide a link to the source code of the Component UI component.

Thank you!

[rogyar]

You may also add a "Source files" section to the document. Please, check the following PR as an example

https://github.com/magento/devdocs/pull/6872/files#diff-bdabb6f71fb335895e4b4762bd05e102R20

[filmaj]

@Jehangir-Wahid i can see you signed the CLA twice, but you entered your github username incorrectly.

In the signed document, you entered jehangirwahid as your username. Please enter your username correctly, with the dash included, i.e. Jehangir-Wahid.

Attached a screenshot of what I see in the document database:

[Jehangir-Wahid]

Hi Rogyar,

Thank you for all of the suggestions. I will alter it accordingly shortly.

[Jehangir-Wahid]

@filmaj,

Yeah you are absolutely right.
I am going to fill it with the correct username.

Thank you.

[dobooth]

Asking @serhiyzhovnir to review for consistency with other UI documentation.

[rogyar]

Example from the codebase:

https://github.com/magento/magento2/blob/2.3/app/code/Magento/AsynchronousOperations/view/adminhtml/ui_component/bulk_details_form.xml#L83

[serhiyzhovnir]

Hi @Jehangir-Wahid
Thank you for your contribution.
I have the following suggestions for this PR:

• Add the component configuration option. Example: https://github.com/magento/devdocs/blame/master/src/guides/v2.3/ui_comp_guide/components/ui-columns.md#L12
• Add the Source files section, it should contain the links to all files that are related to this component. Example: https://github.com/magento/devdocs/blame/master/src/guides/v2.3/ui_comp_guide/components/ui-columns.md#L31-L36
• Add the link to component page. Example: https://github.com/magento/devdocs/blob/master/src/_data/toc/ui-components-guide.yml#L54-L56

Could you, please, check all suggesions and let me know if any questions.

Thank you!

[Jehangir-Wahid]

Hi @serhiyzhovnir,

Yeah, for sure.

[Jehangir-Wahid]

Hi @serhiyzhovnir,

I have committed some changes in my branch, please review it. Thanks

Also I want to let you know that I didn't find a js file for the container component. Therefore didn't added the component configuration option and also couldn't added any js file path in the Source files section.

Please, guide me if I am missing something and/or if there is a js file for it so that I can add it in the documentation.

Thanks

[dobooth]

Thanks for the help, gents!

[dobooth]

running tests

[ghost]

Hi @Jehangir-Wahid, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.