Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

#681: [Test coverage] missed or empty "cart_id" in cart operations #711

Merged

Conversation

sergiy-v
Copy link

Description (*)

Added the following API-functional tests cases.

\Magento\GraphQl\Quote\Customer\RemoveCouponFromCartTest
testRemoveCouponFromCartIfCartIdIsMissed
testRemoveCouponFromCartIfCartIdIsEmpty

\Magento\GraphQl\Quote\Guest\RemoveCouponFromCartTest
testRemoveCouponFromCartIfCartIdIsMissed
testRemoveCouponFromCartIfCartIdIsEmpty

\Magento\GraphQl\Quote\Customer\PlaceOrderTest
testPlaceOrderIfCartIdIsMissed
testPlaceOrderIfCartIdIsEmpty

\Magento\GraphQl\Quote\Guest\PlaceOrderTest
testPlaceOrderIfCartIdIsMissed
testPlaceOrderIfCartIdIsEmpty

\Magento\GraphQl\Quote\Guest\GetCartTest
testGetCartIfCartIdIsMissed
testGetCartIfCartIdIsEmpty

\Magento\GraphQl\Quote\Customer\GetCartTest
testGetCartIfCartIdIsMissed
testGetCartIfCartIdIsEmpty

\Magento\GraphQl\Quote\Guest\AddSimpleProductToCartTest
testAddSimpleProductToCartIfCartIdIsMissed
testAddSimpleProductToCartIfCartIdIsEmpty
testAddSimpleProductToCartIfCartItemsAreMissed
testAddSimpleProductToCartIfCartItemsAreEmpty

\Magento\GraphQl\Quote\Customer\AddSimpleProductToCartTest
testAddSimpleProductToCartIfCartIdIsMissed
testAddSimpleProductToCartIfCartIdIsEmpty
testAddSimpleProductToCartIfCartItemsAreMissed
testAddSimpleProductToCartIfCartItemsAreEmpty

\Magento\GraphQl\Quote\Guest\AddVirtualProductToCartTest
testAddVirtualProductToCartIfCartIdIsMissed
testAddVirtualProductToCartIfCartIdIsEmpty
testAddVirtualProductToCartIfCartItemsAreMissed
testAddVirtualProductToCartIfCartItemsAreEmpty

\Magento\GraphQl\Quote\Customer\AddVirtualProductToCartTest
testAddVirtualProductToCartIfCartIdIsMissed
testAddVirtualProductToCartIfCartIdIsEmpty
testAddVirtualProductToCartIfCartItemsAreMissed
testAddVirtualProductToCartIfCartItemsAreEmpty

Fixed Issues (if relevant)

  1. [Test coverage] Missed or empty "cart_id" in cart operations #681

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lenaorobei
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5220 has been created to process this Pull Request

@naydav naydav merged commit a7bdee7 into magento:2.3-develop Jun 12, 2019
@ghost
Copy link

ghost commented Jun 12, 2019

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants