Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

add Magento_QuoteGraphQl dependency to Magento_ConfigurableProductGra… #859

Conversation

danslo
Copy link
Contributor

@danslo danslo commented Aug 26, 2019

Description (*)

The Magento_ConfigurableProductGraphQl module has a reference to CartItemInput. This type is defined in Magento_QuoteGraphQl.

Manual testing scenarios (*)

  • Remove a couple of modules using replace: "*" in composer.json.
  • Run setup:upgrade, modules will reorder in app/etc/config.php in such a way that Magento_ConfigurableProductGraphQl is loaded before Magento_QuoteGraphQl.
  • GraphQL schema stitching will now fail because of wrong depdendency order.

Questions or comments

This case is already covered by integration test Magento\GraphQl\Controller\GraphQlControllerTest, but it didn't catch because this test is run with all modules enabled, this wasn't the case for our project.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…phQl

The Magento_ConfigurableProductGraphQl module has a reference to CartItemInput.
This type is defined in Magento_QuoteGraphQl.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 26, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5701 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team magento-engcom-team merged commit ccf86d3 into magento:2.3-develop Aug 29, 2019
@ghost
Copy link

ghost commented Aug 29, 2019

Hi @danslo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants