Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE-1079: declare(strict_types=1) causes static code check failure #154

Merged
merged 6 commits into from
Jun 26, 2018
Merged

MQE-1079: declare(strict_types=1) causes static code check failure #154

merged 6 commits into from
Jun 26, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Updated Codesniffer to Magento2CE version
  • Updated existing static checks to use new PHPCS version, fixed failing static checks

Fixed Issues

  1. declare(strict_types=1) causes static code check failure #72

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1079: declare(strict_types=1) causes static code check failure
eefed8f 
- Updated PHPCodeSniffer version + sniffs.
- Removed various @ignore flags in files and fixed errors
@KevinBKozan
MQE-1079: declare(strict_types=1) causes static code check failure
c6ec300 
- Additional static check fixes.
@KevinBKozan
MQE-1079: declare(strict_types=1) causes static code check failure
92a644a 
- Re-implemented function doc/variable checks.
- Static fixes for above.
@KevinBKozan
MQE-1079: declare(strict_types=1) causes static code check failure
0cdacdf 
- Added two squizzlab checks to blacklist
@KevinBKozan
Merge branch 'develop' into MQE-1079
b89bb56
@KevinBKozan
MQE-1033: Validate duplicate element names in the same file (Section,…
4ed5609 
… Data, Metadata, Page)

- Bringing composer version up to parity with Magento2CE
- Merge develop and fix failures there.
@KevinBKozan KevinBKozan merged commit 95aa636 into develop Jun 26, 2018
@KevinBKozan KevinBKozan deleted the MQE-1079 branch June 26, 2018 15:46
@KevinBKozan KevinBKozan mentioned this pull request Jun 26, 2018
Closed
magento-devops-reposync-svc pushed a commit that referenced this pull request Jan 31, 2022
@KevinBKozan
Merge pull request #154 from magento-gl/MQE-1190
4191e71 
MQE-1190: Do not truncate parameters when using MFTF run:test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KevinBKozan