MAGETWO-46837: Implementing extension to wait for readiness metrics t…

[pdohogne-magento]

Code review for MAGETWO-46837 Readiness Check extension

[magento-cicd2]

All committers have signed the CLA.

[coveralls]

Coverage decreased (-0.03%) to 56.173% when pulling b462aa8 on magento-borg:MAGETWO-46837-readiness-flag-develop into 45d802b on magento:develop.

[imeron2433]

Instead of storing the test param, what do you think about just keeping it as a function variable for each of your event functions? I see the only place you use it where you don't have access to an event is in the logDebug function, but you could pass it in as an arg instead of relying on the class to store the test variable.

[pdohogne-magento]

That depends on how Codeception handles events. I use the test object from the beforeTest event to track metric failure data ( $test->getMetadata()->setCurrent() ), so if the test object attached to the step events gets recreated or the metadata isn't otherwise persisted between events then that tracking functionality is lost.

I could move that tracking out of the test object and into an extension-specific construct directly instead, though I'd still be passing that around between metrics. Any objections?

[imeron2433]

Hmm that's a good point. I guess I'd only be concerned about tethering ourselves to codeception's test object for your metadata, but I don't feel that strongly about it atm. @okolesnyk or @magterskine any thoughts?

[okolesnyk]

@pdohogne-magento @imeron2433 @magterskine
I think in our case when we need to release this next week we can leave it as it is for now. And probably do the refactoring when the story about skip metrics attribute for actions will be in progress.