Non-API operations fixes

[ameysar]

Description

• Fixes assignment of the correct value for object return property
• Fix assignment of the correct operation method

Steps to reproduce

• Magento 2.3.2 CE
• Change app/code/Magento/CatalogRule/Test/Mftf/Metadata/catalog-rule-meta.xml
  • createCatalogRule operation change url to /catalog_rule/promo_catalog/save/back/edit and add returnRegex="~\/id\/(\d+?)\/~"
  • imlement delete operation
    <operation name="DeleteCatalogRule" dataType="catalogRule" type="delete" auth="adminFormKey" url="/catalog_rule/promo_catalog/delete/id/{return}" method="POST" successRegex="/messages-message-success/"> </operation>
• Create and run test
  <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd"> <test name="CreateCatalogRuleApiTest"> <createData entity="_defaultCatalogRule" stepKey="createCatalogRule"/> <deleteData createDataKey="createCatalogRule" stepKey="deleteCatalogRule"/> </test> </tests>

Expected result

Test passed successfully

Actual result

Test failed

Notice

• The first problem is that createData assign array to object return field
• The second - delete operation method is taken by operation type mapping, despite operation method is defined

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/verification tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)
• Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

[magento-cicd2]

All committers have signed the CLA.

[coveralls]

Coverage increased (+0.7%) to 52.864% when pulling 66c5214 on ameysar:fix-non-api-operations into 3c7ed4b on magento:develop.

[KevinBKozan]

@ameysar thank you for your contribution! We'll be reviewing the code changes and tracking its progress internally. We'll keep this PR updated with the appropriate labels to let you know the status of the code review.

[jilu1]

@ameysar The other codes look good, please address the area with comments. Thank you!

[ameysar]

@jilu1 all comments are fixed. Please proceed with CR

[jilu1]

Minor comment about using 0 as default index.

[ameysar]

@jilu1 please proceed with CR