Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call to a member function getId() on array in module-sales/view/adminhtml/templates/order/totals/tax.phtml:62 #30094

Closed
pjayramkumar opened this issue Sep 17, 2020 · 46 comments
Closed

Call to a member function getId() on array in module-sales/view/adminhtml/templates/order/totals/tax.phtml:62 #30094

pjayramkumar opened this issue Sep 17, 2020 · 46 comments
Labels
Component: Sales Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@pjayramkumar
Copy link
Member

pjayramkumar commented Sep 17, 2020 •
edited by ihor-sviziev
Loading

Preconditions (*)

  1. Magento Version 2.4.0

Steps to reproduce (*)

  1. Go to Store -> Configuration -> Sales -> Tax -> Orders, Invoices, Credit Memos Display Settings -> Display Full Tax Summary and change to YES
  2. Go to Sales -> Orders -> Open Order -> Invoice Tab -> Open Invoice -> Page View Source -> Issue will Visible at the end of view source Page

Expected result (*)

  1. <Screenshots, logs or description]
  2. Screenshot 2020-09-17 at 9 54 45 PM
  3. $rate->getId() should be like $rate['id']

4.Screenshot 2020-09-17 at 9 57 24 PM
need to expand this array and add id as key to get in the result to the Magento\Tax\Model\ResourceModel\Calculation
Screenshot 2020-09-17 at 9 59 34 PM
add the ID CONST in the Magento\Tax\Model\Sales\Order\Tax class

Actual result (*)

  1. [Screenshots, logs or description]

Screenshot 2020-09-17 at 10 00 56 PM

Additional info from Engcom

Switch Magento into Developer mode to reproduce the issue bin/magento dep:mo:set developer
The invoice looks like this
html_invoice

Error from View Page Source
Selection_017
@m2-assistant
Copy link

m2-assistant bot commented Sep 17, 2020

Hi @pjayramkumar. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 17, 2020
@pjayramkumar
Copy link
Member Author

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Sep 17, 2020

Hi @pjayramkumar! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@pjayramkumar
Copy link
Member Author

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Sep 17, 2020

Hi @pjayramkumar! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@pjayramkumar
Copy link
Member Author

@magento add to contributors team

@engcom-Oscar engcom-Oscar added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Sep 18, 2020
@itsolon
Copy link

itsolon commented Sep 24, 2020

i can confirm this behaviour

@irshadcedcoss
Copy link

@magento I am working on this

@GovindaSharma
Copy link
Contributor

@magento I am working on this

@Morgy93 Morgy93 mentioned this issue Oct 16, 2020
Closed
4 tasks
@22markets
Copy link

I can confirm this error on 2.4.0 and 2.4.1

@Morgy93
Copy link
Member

Morgy93 commented Oct 16, 2020

Error introduced here 70ede03

@Morgy93
Copy link
Member

Morgy93 commented Oct 16, 2020

@magento I am working on this

@Morgy93
Copy link
Member

Morgy93 commented Oct 16, 2020

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @Morgy93. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @Morgy93, here is your Magento Instance: https://a068cefc821315523684f4ab4b839e24-2-4-develop.instances.magento-community.engineering
Admin access: https://a068cefc821315523684f4ab4b839e24-2-4-develop.instances.magento-community.engineering/admin_d8d0
Login: 9a2db200
Password: 0f74394a9637

This was referenced Oct 16, 2020
Closed
Closed
@mrtuvn mrtuvn added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Progress: ready for dev labels Jul 31, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @mrtuvn
Thank you for verifying the issue. Based on the provided information internal tickets MC-38991 were created

Issue Available: @mrtuvn, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@mrtuvn mrtuvn added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Aug 7, 2021
@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label Aug 10, 2021
@hostep
Copy link
Contributor

hostep commented Aug 11, 2021 •
edited
Loading

It looks like core Magento devs have finally seen the light even though the community had a PR open for this for almost a year now. So they just publised a fix in: MC-42332: part 1, part 2

I'm guessing it will be released in Magento 2.4.4 which will probably be released somewhere in 2022, yay!

@ihor-sviziev
Copy link
Contributor

Hi @pjayramkumar,
As @hostep mentioned, looks like the issue was fixed in the 2.4-develop branch with the following commits:

Could you confirm that?

@o-dubovyk
Copy link
Contributor

Issue was fixed and delivered in pull request as was mentioned above

@o-dubovyk
Copy link
Contributor

This issue was fixed with the following commits: d648bdc, 3ae814c. Closing this issue

@sdzhepa sdzhepa closed this as completed Aug 19, 2021
magento-engcom-team added a commit that referenced this issue Aug 20, 2021
@magento-engcom-team
ENGCOM-9169: fix #30094 function call on array #30516
24a242f 
 - Merge Pull Request #30516 from Morgy93/magento2:fix-30094
 - Merged commits:
   1. 40df5c8
   2. b7e6429
magento-engcom-team pushed a commit that referenced this issue Aug 20, 2021
@gabrieldagama
ENGCOM-9169: fix #30094 function call on array #30516
ef2691a
@itsolon
Copy link

itsolon commented Nov 29, 2021

It looks like core Magento devs have finally seen the light even though the community had a PR open for this for almost a year now. So they just publised a fix in: MC-42332: part 1, part 2

I'm guessing it will be released in Magento 2.4.4 which will probably be released somewhere in 2022, yay!

hopefully this will fix my issue tooo yay :-) thank you for that

@jaykobi
Copy link

jaykobi commented Sep 20, 2022 •
edited
Loading

Two years later... bug still present in Magento 2.4.5

@ihor-sviziev
Copy link
Contributor

@jaykobi, accodring to the following line, it shouldn't reproduce on 2.4.5.

magento2/app/code/Magento/Sales/view/adminhtml/templates/order/totals/tax.phtml

Line 63 in d648bdc

<tr id="rate-<?= $rateRow ?>"

If you can reproduce this issue on clean magento installation, please report a separate issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Sales Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #30094 function call on array
fix #30094 function call on array