Wrong parameter for getting base url for 'media' path in "Image" form element. #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request. We will process it internally through ticket MAGETWO-33727 and merge your pull request after that. |
|
CR: passed |
vpelipenko
added a commit
that referenced
this pull request
Feb 13, 2015
Wrong parameter for getting base url for 'media' path in "Image" form element.
otoolec
added a commit
that referenced
this pull request
Feb 13, 2015
…in "Image" form element. #1025 - Import UrlInterface to short line to under 120 characters - Add integration test to catch regression - Modify unit test to catch regression
magento-team
added a commit
to abeeskau/magento2-community-edition
that referenced
this pull request
Feb 20, 2015
* Various improvements:
* Existing Builders were replaced with DataFactories in Customer and Tax modules
* Refactored controller actions in the Checkout and CMS modules
* Increased coverage with static tests for `.phtml` files
* Moved Cookie related functionality from `Theme` and `Core` modules into a new `Cookie` module
* Moved minfication configuration settings to the `View` library level
* UI improvements:
* Restyled installation wizard
* Prepared styles for Dashboard in the Backend area
* Framework improvements:
* Added `setCustomAttribute` and `setCustomAttributes` methods to `ExtensibleDataInterface`
* Added setter methods to data object interfaces
* Replaced `Builders` with `Factories`
* Added `DataObjectHelper.php` which contains the common set of methods of all builders
* Refactored `__()` to return `Phrase` object
* Allowed usage of `LocalizedException` on the framework's library level
* Added expiration/lifetime management of frontend resources
* Unified MTF configurations format for Framework, TestCase variations and TestCase scenario configurations
* Fixed bugs:
* Fixed an issue with product reviews list paging
* Fixed an issue where sold products were not displayed in Bestsellers
* Fixed an issue with image rendering on the CMS page on Frontend when `webserver rewrites = no`
* GitHub requests:
* [#790](magento/magento2#790) -- Magento API fails in a CGI env (zf1 issue)
* [#909](magento/magento2#909) -- Manage Titles in popup window front-end issue
* [#996](magento/magento2#996) -- Pager block should support url "fragment".
* [#985](magento/magento2#985) -- Allow camelcase in vendorname for menus
* [#1025](magento/magento2#1025) -- Wrong parameter for getting base url for 'media' path in "Image" form element.
magento-team
pushed a commit
that referenced
this pull request
Apr 14, 2017
[Folks] Api Annotation Coverage of OMS-related Modules
VitaliyBoyko
pushed a commit
to VitaliyBoyko/magento2
that referenced
this pull request
Jun 22, 2018
MSI-724: Implement IsCorrectQtyConditionTest::testExecuteWithQtyIncrements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form element "image" doesn't load 'media' path.
http://dl1.joxi.net/drive/0000/0178/12466/150206/57a3f0519b.jpg
\Magento\Framework\UrlInterface::getBaseUrl accepts an array instead of a string.