Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatalogImportExport validation #1274

Conversation

bartdelvaux
Copy link
Contributor

No description provided.

Updated the processed rows count after validation of a row. 
This fixes that you don't get the message that the imported file is empty after starting a productimport with the ImportExport.
Use the existing constant because the constant is not available in the Magento\CatalogImportExport\Model\Import\Product class.
@bartdelvaux
Copy link
Contributor Author

This pull request solves 2 issues when doing a catalog product import.

The first issue appears when you have a required attribute in your configuration and you import new products. With this fix, you solves an error of using an undefined class constant.

The second issue appears with the validation of the file. A message was returned that a file was empty (even there is data in). This issue was solved by updating the processed rows count.

@bartdelvaux bartdelvaux changed the title Bartdelvauxx catalogimportexport validation Catalogimportexport validation May 12, 2015
@bartdelvaux bartdelvaux changed the title Catalogimportexport validation CatalogImportExport validation May 12, 2015
@vpelipenko vpelipenko added the MX label May 13, 2015
@vpelipenko
Copy link
Contributor

Integration tests were failed, probably environment issue. I've just restarted this job.

@kokoc kokoc self-assigned this May 15, 2015
@kokoc
Copy link
Member

kokoc commented May 15, 2015

@bartdelvauxx Thank you for the contribution!

CR: passed
Resolution: ready to merge
Internal reference: MAGETWO-37499
Builds: Green

@magento-team magento-team merged commit 75e4cb4 into magento:develop May 22, 2015
@kokoc
Copy link
Member

kokoc commented May 27, 2015

@bartdelvauxx your pull request is merged in 0.74.0-beta10. Thank you very much for your contribution and continued support to Magento 2!

VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this pull request Jun 22, 2018
Cannot cancel order with deleted product.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants