Permissions not set correctly #1453 #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are currently only changing to 644 which still allows anyone with system access to read the files. I think there will always be a need for the person deploying to accurately set permissions for their system requirements but if permissions are changed I would advocate to change the default to the strictest possible (700/600). This would then make giving extra permissions an explicit step. |
|
@fooman git only tracks perms of 644/755 i believe. this ticket was just to tighten up the files that were set to 755 (all files should be 644 except bin/magento). |
magento-team
pushed a commit
that referenced
this pull request
Sep 4, 2017
Fixed issues: - MAGETWO-72261: Merge 2.2-develop into develop
magento-engcom-team
added a commit
that referenced
this pull request
Mar 16, 2018
- Merge Pull Request magento-engcom/magento2ce#1454 from magento-engcom/magento2ce:codetriage-badge-2.1 - Merged commits: 1. a745fc5
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.