Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] 1190: CreateOrderBackendPartOneTest rework to support MSI reservation mechanism. #16625

Closed
wants to merge 1 commit into from
Closed

Conversation

mageprince
Copy link
Contributor

@mageprince mageprince commented Jul 8, 2018

Original Pull Request

#16153

Description

Add shipment step to CreateOrderBackendPartOneTest in order to support MSI reservation mechanism.

Standard magento behaviour - product quantity decreased immediately after place order, but with MSI quantity decreasing only after shipment created, as MSI introduces additional property for product as 'salable quantity'. And after order placement, 'salable quantity' decreasing, not quantity itself(more about reservation mechanism here). Quantity decreasing only after shipment creation. So, in order to pass CreateOrderBackendPartOneTest with MSI, additional step with shipment creation should be added into test before assertions.

Fixed Issues (if relevant)

  1. Fix Functional Test Magento\Sales\Test\TestCase\CreateOrderBackendPartOneTest::test with data set "CreateOrderBackendTestVariation1_0" inventory#1190: Fix Functional Test Magento\Sales\Test\TestCase\CreateOrderBackendPartOneTest::test with data set "CreateOrderBackendTestVariation1_0"

Manual testing scenarios

  1. None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov sidolov self-assigned this Jul 25, 2018
@sidolov
Copy link
Contributor

sidolov commented Jul 25, 2018

Hi @mageprince , provided changes made especially for 2.3 release line to support MSI project and not applicable for 2.2 release line. I'm closing this PR as not relevant.

@sidolov sidolov closed this Jul 25, 2018
@mageprince mageprince deleted the 2.2-develop-PR-port-16153 branch July 25, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants